Pr finalize v1alpha2#462
Conversation
…bug, also copy addons to examples output folder, Re-sync makefile
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/assign @jichenjc After this only the staging release job (#460) and docs should be left for v1alpha2 |
| export OPENSTACK_CLOUD_PROVIDER_CONF6 | ||
| OPENSTACK_CLOUD_PROVIDER_CONF6=$(echo "${OPENSTACK_CLOUD_PROVIDER_CONF}" | sed -e 's/^/ /') | ||
| export OPENSTACK_CLOUD_PROVIDER_CONF10 | ||
| OPENSTACK_CLOUD_PROVIDER_CONF10=$(echo "${OPENSTACK_CLOUD_PROVIDER_CONF}" | sed -e 's/^/ /') |
There was a problem hiding this comment.
I didn't get this CONF6/CONF10 ... what's the meaning of this?
There was a problem hiding this comment.
The problem is that I sometimes need the config with indent 6 (KubeadmConfig) and sometimes with indent 10 (KubeadmConfigTemplate). Seems to be the easiest way to just have to vars for envsubst.
examples/generate.sh
Outdated
|
|
||
| # Generate Cluster API provider components file. | ||
| kustomize build "github.com/kubernetes-sigs/cluster-api//config/default/?ref=master" --reorder=none > "${COMPONENTS_CLUSTER_API_GENERATED_FILE}" | ||
| kustomize build "github.com/kubernetes-sigs/cluster-api//config/default/?ref=master" > "${COMPONENTS_CLUSTER_API_GENERATED_FILE}" |
|
@jichenjc ptal :) |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
@sbueringer could you share your YAML for creating MM cluster with LBaaS, as well as single node cluster without LBaaS? It would be greatly appreciated!! |
That's the one for single node control plane: But please just use the documentation (and examples/generate.sh), which should be up-to-date with this PR: #474 There's also an issue to generate separate single-node and multi-node control plane examples: #473 I also have my dev-env published here: https://github.com/sbueringer/capi-dev/tree/master/cluster Which first generates examples with the scripts from the repo and then kustomizes them to my env. If you have further questions you can always ask :) |
* Re-sync controller implementation with CAPA, Fix cloud config indent bug, also copy addons to examples output folder, Re-sync makefile * update * fix image name, more sync * Update generate.sh
5 participants
Final fixes for v1alpha2. This has been tested with: